Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

consider backporting ITS#8324 to grow file incrementally on Windows #40

Closed
mykmelez opened this issue Mar 29, 2019 · 2 comments
Closed
Labels
ARCHIVED CLOSED at time of archiving

Comments

@mykmelez
Copy link

mykmelez commented Mar 29, 2019

Per ITS#8324, LMDB creates a database file at the map size on Windows rather than incrementally growing the file as on other platforms. The fix for that issue landed on the LMDB master branch several years ago, but it hasn't yet been backported to the release branch.

Note this comment about why the fix wasn't backported. However, from cursory inspection, LMDB/lmdb@e85ae1f might have since addressed that problem.

In any case, since the fix for ITS#8324 hasn't landed upstream, and since it impacts lmdb-rs consumers (per #23), we should consider taking it downstream. That would mean taking not only the original commit but also its follow-ups. This list of commits containing the string "ITS#8324" is presumably the set we would need to backport.

@mykmelez
Copy link
Author

This email message explains in more detail why the fix wasn't backported. Based on that explanation, it seems like a bad idea for us to do so:

http://www.openldap.org/lists/openldap-bugs/201902/msg00009.html

@iainnicol
Copy link

FWIW, I encountered this running MeiliSearch on Windows.

I see from your link there's an unfortunate trade off for enabling this feature, in terms of performance. What is new is that this is now compile-term optional (in upstream lmdb): LMDB/lmdb@147582b

So that's good. But I presume, understandably, the intention would be to wait until LMDB v1.0, before considering merging such code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARCHIVED CLOSED at time of archiving
Projects
None yet
Development

No branches or pull requests

3 participants