-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] JWT valid only for a specific room #78
Comments
That sounds like a totally reasonable thing to have. |
I think I would prefer to implement it slightly differently. I would consider |
That can work too. This is why I asked for opinion, thanks. ;-) |
Oops, I did it! |
:D Thank you. I'll create more issues like this if you can't help yourself of implementing it. ;-) |
I'm having fun working on this a little bit so go for it. |
Related to the JWT (see #77).
Currently the JWT content can contains
{ join_hub: true, kick_users: true }
because the security model of Hubs was giving access to all rooms in the Hubs Cloud instance. For my use case, I may need more security, only giving access to one or more rooms so I think it would make sense to add an additional optional room_ids parameter like this{ kick_users: true, room_ids: ["123", "456"] }
(make it plural to support main room with breakout rooms right away)
room_ids and join_hub should be mutually exclusive, only one of this parameter should be in the JWT.
Thoughts?
The text was updated successfully, but these errors were encountered: