-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only offer active homepage locales on / site root #15010
Comments
For now it seems that the Compare Basically none of the root language selection gets filtered to PROD_LANGUAGES or DEV_LANGUAGES, only to locale map from product-details, otherwise anything that's in the metadata json as active_locale gets exposed all the way through. |
Actually not only there are disabled languages being offered. There are also a handful missing: https://www.textcompare.org/?id=66cf6c8bba091793598346ea (full diff in the link, but basically some European and Asian languages like az, bg, et, gu, hy, lt, ta, ur missing.)
|
This is getting a bit complicated now with three home ftls:
with varying activation metadata. Normally a "good enough" check might be for the activation of the oldest A corner case might be e.g. a locale that never had home-old or home-new translated, but got active recently and completed home-m24 localization — such language should also be listed in the global root as active. |
Description
Originally posted by @janbrasna in #15007 (comment):
Steps to reproduce
Open https://www.mozilla.org/ with Accept-Language header empty to get to the locale selection page (i.e. this from crawlers PoV), and check all the links work.
(Alternative hreflangs meta for / home follows the same pattern, and differs for the list of hreflangs for /en home — TODO: investigate why the active locales are assessed with different results here… Generated sitemaps seem unaffected by this.)
Expected result
Only working locales linked.
Actual result
https://www.mozilla.org/ach › default fallback
https://www.mozilla.org/lo › /en-US/lo/ 404
https://www.mozilla.org/mk › default fallback
https://www.mozilla.org/km › default fallback
https://www.mozilla.org/tg › /en-US/tg/ 404
https://www.mozilla.org/tl › default fallback
Environment
Overrides with googlebot UA string, empty Accept-Locale etc.
The text was updated successfully, but these errors were encountered: