Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private methods in the grammar #630

Closed
arai-a opened this issue Aug 31, 2020 · 2 comments
Closed

Add private methods in the grammar #630

arai-a opened this issue Aug 31, 2020 · 2 comments
Assignees
@arai-a

Comments

@arai-a
Copy link
Collaborator

arai-a commented Aug 31, 2020

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314514767&repo=mozilla-central&lineNumber=123691

## test262/language/arguments-object/cls-expr-private-gen-meth-static-args-trailing-comma-single-args.js: rc = 3, run time = 0.054069
...
<unknown>:1:0 SyntaxError: syntax error on: Token { terminal_id: PrivateIdentifier, loc: SourceLocation { start: 1251, end: 1258 }, is_on_new_line: false, value: Atom(SourceAtomSetIndex { index: 59 }) }
TEST-UNEXPECTED-FAIL | test262/language/arguments-object/cls-expr-private-gen-meth-static-args-trailing-comma-single-args.js | (args: "--smoosh") [0.1 s]
@arai-a
Copy link
Collaborator Author

arai-a commented Aug 31, 2020

so, basically this is https://tc39.es/proposal-private-methods/

@arai-a arai-a changed the title Properly throw not-implemented for private generator Add private methods in the grammar Aug 31, 2020
@arai-a
Copy link
Collaborator Author

arai-a commented Aug 31, 2020

https://treeherder.mozilla.org/#/jobs?repo=try&revision=53e70e6661f3b1f7986a1a5daa615604f2e7134f

@arai-a arai-a self-assigned this Aug 31, 2020
arai-a added a commit to arai-a/jsparagus that referenced this issue Sep 1, 2020
@arai-a
Add private methods to the grammar rule (fixes mozilla-spidermonkey#630)
fbd529b
@arai-a arai-a closed this as completed in b4bcfed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arai-a arai-a

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arai-a