Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EmitResult.top_level_script #629

Closed
arai-a opened this issue Aug 23, 2020 · 1 comment
Closed

Remove EmitResult.top_level_script #629

arai-a opened this issue Aug 23, 2020 · 1 comment
Assignees
@arai-a

Comments

@arai-a
Copy link
Collaborator

arai-a commented Aug 23, 2020 •
edited
Loading

SpiderMonkey-side will remove CompilationInfo.topLevel in https://bugzilla.mozilla.org/show_bug.cgi?id=1658720
The bug itself can be fixed without this change, by shifting the function index +1.
@arai-a arai-a self-assigned this Aug 29, 2020
@arai-a
Copy link
Collaborator Author

arai-a commented Aug 29, 2020

m-c patch is landed.

arai-a added a commit to arai-a/jsparagus that referenced this issue Sep 1, 2020
@arai-a
Remove EmitResult.top_level_script and use EmitResult.scripts for bot…
af9f930 
…h top level script and functions (fixes mozilla-spidermonkey#629)
@arai-a arai-a closed this as completed in 2800417 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arai-a arai-a

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arai-a