diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index f83f7f6fab..54d3c7b025 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -29,7 +29,7 @@ RUN /tmp/set_up_stackwalker.sh && \ # Install frontend JS deps COPY --chown=app:app ./webapp/package*.json /webapp-frontend-deps/ -RUN cd /webapp-frontend-deps/ && npm install +RUN cd /webapp-frontend-deps/ && npm ci # NOTE(relud): these dependencies are installed separately, relocated, and patched to reference the # new location (aka shaded), so that they can be installed at the same time as newer versions @@ -52,6 +52,5 @@ ENV PYTHONUNBUFFERED=1 \ PYTHONDONTWRITEBYTECODE=1 \ PYTHONPATH=/app \ UGLIFYJS_BINARY=/webapp-frontend-deps/node_modules/.bin/uglifyjs \ - CSSMIN_BINARY=/webapp-frontend-deps/node_modules/.bin/cssmin \ NPM_ROOT_PATH=/webapp-frontend-deps/ \ NODE_PATH=/webapp-frontend-deps/node_modules/ diff --git a/docker/Dockerfile b/docker/Dockerfile index b4b613b316..e67be91d26 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -30,7 +30,7 @@ RUN /tmp/set_up_stackwalker.sh && \ # Install frontend JS deps COPY --chown=app:app ./webapp/package*.json /webapp-frontend-deps/ -RUN cd /webapp-frontend-deps/ && npm install +RUN cd /webapp-frontend-deps/ && npm ci # NOTE(relud): these dependencies are installed separately, relocated, and patched to reference the # new location (aka shaded), so that they can be installed at the same time as newer versions @@ -47,7 +47,6 @@ ENV PYTHONUNBUFFERED=1 \ PYTHONDONTWRITEBYTECODE=1 \ PYTHONPATH=/app \ UGLIFYJS_BINARY=/webapp-frontend-deps/node_modules/.bin/uglifyjs \ - CSSMIN_BINARY=/webapp-frontend-deps/node_modules/.bin/cssmin \ NPM_ROOT_PATH=/webapp-frontend-deps/ \ NODE_PATH=/webapp-frontend-deps/node_modules/ @@ -57,9 +56,7 @@ USER app # Copy everything over COPY --chown=app:app . /app/ -# Run collectstatic in container which puts files in the default place for -# static files -RUN cd /app/webapp/ && TOOL_ENV=True python manage.py collectstatic --noinput +RUN cd /app/webapp/ && npm run build # Set entrypoint for this image. The entrypoint script takes a service # to run as the first argument. See the script for available arguments. diff --git a/webapp/crashstats/crashstats/jinja2/crashstats_base.html b/webapp/crashstats/crashstats/jinja2/crashstats_base.html index 77bdc41ab1..ae348041e2 100644 --- a/webapp/crashstats/crashstats/jinja2/crashstats_base.html +++ b/webapp/crashstats/crashstats/jinja2/crashstats_base.html @@ -16,10 +16,7 @@ {% endblock %} {% endblock %} - {% block site_css %} - {% stylesheet 'crashstats_base' %} - {% stylesheet 'fontawesome' %} - {% endblock %} + diff --git a/webapp/crashstats/crashstats/jinja2/error_base.html b/webapp/crashstats/crashstats/jinja2/error_base.html index d41e2d0aa8..5038c5f045 100644 --- a/webapp/crashstats/crashstats/jinja2/error_base.html +++ b/webapp/crashstats/crashstats/jinja2/error_base.html @@ -3,9 +3,7 @@ {% block page_title %}Error{% endblock %} - {% block site_css %} - {% stylesheet 'crashstats_base' %} - {% endblock %} +