Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pruning optional for debugging #256

Closed
v4hn opened this issue Apr 23, 2021 · 3 comments
Closed

Make pruning optional for debugging #256

v4hn opened this issue Apr 23, 2021 · 3 comments

Comments

@v4hn
Copy link
Contributor

v4hn commented Apr 23, 2021

We recently reworked pruning (#221, #250, #252). It works more reliable now and can reduce computational overhead quite a lot.
However, for debugging, it can be useful to attempt all possible computations.
This can help to identify culprits and identify longest partial solutions in the current design.

I would propose to add a pruning property to the Task container and allow users to call setPruning(false) if they want to do so.

@rhaschke
Copy link
Contributor

Maybe, instead of defining this property in the top-level task container only, you want to do so at the individual container level?
I also suggest automatically inheriting this property from the parent.

@v4hn
Copy link
Contributor Author

v4hn commented Apr 24, 2021

Maybe, instead of defining this property in the top-level task container only, you want to do so at the individual container level?
I also suggest automatically inheriting this property from the parent.

Yes. I don't think we could implement it easily any other way, because the individual stages need to be able to see the flag.
I think there are also unresolved issues with default sources for inheritance though - I seem to recall we don't support them at the moment.

@rhaschke
Copy link
Contributor

rhaschke commented Jul 6, 2024

Fixed via #590

@rhaschke rhaschke closed this as completed Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants