Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveGroupInterface does not provide any way to query execution state. #3159

Closed
liarokapisv opened this issue Dec 12, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@liarokapisv
Copy link

liarokapisv commented Dec 12, 2024

Is your feature request related to a problem? Please describe.

Before the ROS2 port, the MoveGroupInterface::getMoveGroupClient returned an actionlib::SimpleActionClient instance which provided state querying capabilities. After the port, it now returns an rclcpp_action::Client instance, which doesn't provide any way to query state. This means one can't properly use the asyncExecute method in practice. As an example, we had issues using the async version for BehaviorTree integration. Instead we had to wrap the blocking version with a thread and do our own state keeping, complicating the solution.

Describe the solution you'd like

Some locals are used in the execute method in order to track execution, perhaps those could turn into member variables and some simple minimal state querying memebr functions could be added. Another approach would be to create a wrapper over the rclcpp_action::Client in order to provide access to current state execution.

@liarokapisv
Copy link
Author

Closing in favor of #3160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant