Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions (multithreading capabilities and GPU integration) #118

Open
HemlockPoison opened this issue Sep 17, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@HemlockPoison
Copy link

HemlockPoison commented Sep 17, 2024

Thank you for developing this project. However, I encountered a significant issue with the documentation. While there is online documentation available, I believe it could be more user-friendly. The quick start tutorial is helpful, but the web documentation lacks detailed information about the parameters for each function and explanations of what each function does.
Undoubtedly, this project is very impressive and noteworthy. The addition of multithreading capabilities and GPU integration could significantly enhance its performance, especially during large data calculations. I hope these features will be considered in the future.

@nargesr
Copy link
Member

nargesr commented Sep 30, 2024

Hi @HemlockPoison

Thank you for your feedback. I may not understand your suggestion completely but wanted to highlight that each function in the API includes detailed documentation, so not sure what you mean by "the web documentation lacks detailed information about the parameters for each function and explanations of what each function does."

Additionally, the functions that were used to find the modules are primarily identical to the R version, including function names, so you may refer to the original paper for more information on the methods.

As the sole developer, I am doing my best to maintain the package. I'll keep your suggestions, such as adding multithreading capabilities and GPU integration, in mind for the future. I also welcome anyone interested in contributing to these enhancements.

@nargesr nargesr added the enhancement New feature or request label Oct 9, 2024
@nargesr nargesr changed the title Some suggestions.😊 Some suggestions (multithreading capabilities and GPU integration) Oct 9, 2024
@tuanpham96
Copy link

@nargesr I'm new to wgcna and trying this out. We have a roughly large dataset ~100k cells x 17k genes and I think it would benefit from some parallelism. Do you know which step during findModules may benefit the most from some parallelism? Would it be during calculating adjacency with corrcoef?

@nargesr
Copy link
Member

nargesr commented Oct 30, 2024

Hi @tuanpham96,

Thank you so much for expressing your interest in PyWGCNA. I would suggest you look at the R version of WGCNA to fully understand the method.

There are three functions during findModules() step that would benefit from doing some parallelism

  1. pickSoftThreshold()
  2. 'adjacency()'
  3. TOMsimilarity()

I believe TOMsimilarity() is the most time-consuming part.

Please let me know if you have any questions.

Best,
Narges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants