Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gitignore.io data #35

Open
jayvdb opened this issue Jun 9, 2018 · 2 comments
Open

Use gitignore.io data #35

jayvdb opened this issue Jun 9, 2018 · 2 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jun 9, 2018

https://github.com/dvcs/gitignore may be a better maintained set of data

@jayvdb
Copy link
Member Author

jayvdb commented Jun 17, 2018

On a subset of gitignore files which are being managed by coala, the following are the -github+dvcs changes.

diff --git a/assets/gitignore/Java.gitignore b/assets/gitignore/Java.gitignore
index a1c2a23..6143e53 100644
--- a/assets/gitignore/Java.gitignore
+++ b/assets/gitignore/Java.gitignore
@@ -13,7 +13,6 @@
 # Package Files #
 *.jar
 *.war
-*.nar
 *.ear
 *.zip
 *.tar.gz
diff --git a/assets/gitignore/Jekyll.gitignore b/assets/gitignore/Jekyll.gitignore
index 2ca8682..5c91b60 100644
--- a/assets/gitignore/Jekyll.gitignore
+++ b/assets/gitignore/Jekyll.gitignore
@@ -1,4 +1,3 @@
 _site/
 .sass-cache/
-.jekyll-cache/
 .jekyll-metadata
diff --git a/assets/gitignore/Node.gitignore b/assets/gitignore/Node.gitignore
index 4454ba1..621038f 100644
--- a/assets/gitignore/Node.gitignore
+++ b/assets/gitignore/Node.gitignore
@@ -29,14 +29,14 @@ bower_components
 # node-waf configuration
 .lock-wscript
 
-# Compiled binary addons (https://nodejs.org/api/addons.html)
+# Compiled binary addons (http://nodejs.org/api/addons.html)
 build/Release
 
 # Dependency directories
 node_modules/
 jspm_packages/
 
-# TypeScript v1 declaration files
+# Typescript v1 declaration files
 typings/
 
 # Optional npm cache directory
@@ -56,12 +56,3 @@ typings/
 
 # dotenv environment variables file
 .env
-
-# next.js build output
-.next
-
-# vuepress build output
-.vuepress/dist
-
-# Serverless directories
-.serverless
diff --git a/assets/gitignore/Python.gitignore b/assets/gitignore/Python.gitignore
index 894a44c..d07652d 100644
--- a/assets/gitignore/Python.gitignore
+++ b/assets/gitignore/Python.gitignore
@@ -23,7 +23,6 @@ wheels/
 *.egg-info/
 .installed.cfg
 *.egg
-MANIFEST
 
 # PyInstaller
 #  Usually these files are written by a python script from a template
@@ -41,21 +40,16 @@ htmlcov/
 .coverage
 .coverage.*
 .cache
+.pytest_cache/
 nosetests.xml
 coverage.xml
 *.cover
 .hypothesis/
-.pytest_cache/
 
 # Translations
 *.mo
 *.pot
 
-# Django stuff:
-*.log
-local_settings.py
-db.sqlite3
-
 # Flask stuff:
 instance/
 .webassets-cache
@@ -76,7 +70,7 @@ target/
 .python-version
 
 # celery beat schedule file
-celerybeat-schedule
+celerybeat-schedule.*
 
 # SageMath parsed files
 *.sage.py
diff --git a/assets/gitignore/Sass.gitignore b/assets/gitignore/Sass.gitignore
index 159f515..486b32c 100644
--- a/assets/gitignore/Sass.gitignore
+++ b/assets/gitignore/Sass.gitignore
@@ -1,4 +1,2 @@
 .sass-cache/
 *.css.map
-*.sass.map
-*.scss.map

A lot of them look like regressions.

However, https://github.com/dvcs/gitignore/commits/master shows it is being more actively maintained than github's repo, and my patch to github/gitignore#2728 hasnt been reviewed in 12 days, while toptal/gitignore#115 was quickly merged.

So, .. toptal/gitignore#116 will be the test... ;-)

@chfw
Copy link
Member

chfw commented Jun 17, 2018

I see. Will follow your lead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants