From a053cb93b662420445ca542ef5df8893a0c3f132 Mon Sep 17 00:00:00 2001 From: Rhys Howell Date: Thu, 6 Mar 2025 19:55:39 -0500 Subject: [PATCH] chore(validation): remove unused action --- .../src/modules/validation.spec.ts | 29 --------------- .../src/modules/validation.ts | 35 +------------------ 2 files changed, 1 insertion(+), 63 deletions(-) diff --git a/packages/compass-schema-validation/src/modules/validation.spec.ts b/packages/compass-schema-validation/src/modules/validation.spec.ts index 915f804c138..abefc328df5 100644 --- a/packages/compass-schema-validation/src/modules/validation.spec.ts +++ b/packages/compass-schema-validation/src/modules/validation.spec.ts @@ -9,7 +9,6 @@ import reducer, { validationFetched, validationCanceled, validationSaveFailed, - syntaxErrorOccurred, validationFromCollection, VALIDATOR_CHANGED, VALIDATION_CANCELED, @@ -17,7 +16,6 @@ import reducer, { VALIDATION_FETCHED, VALIDATION_ACTION_CHANGED, VALIDATION_LEVEL_CHANGED, - SYNTAX_ERROR_OCCURRED, } from './validation'; describe('validation module', function () { @@ -119,15 +117,6 @@ describe('validation module', function () { }); }); - describe('#syntaxErrorOccurred', function () { - it('returns the SYNTAX_ERROR_OCCURRED action', function () { - expect(syntaxErrorOccurred({ message: 'Syntax Error!' })).to.deep.equal({ - type: SYNTAX_ERROR_OCCURRED, - syntaxError: { message: 'Syntax Error!' }, - }); - }); - }); - describe('validationFromCollection', function () { context('when an error occurs listing the collection', function () { it('includes the error', function () { @@ -324,23 +313,5 @@ describe('validation module', function () { }); }); }); - - context('when the action is syntaxErrorOccurred', function () { - it('returns the new state', function () { - const validation = reducer( - undefined, - syntaxErrorOccurred({ message: 'Syntax Error!' }) - ); - - expect(validation).to.deep.equal({ - validator: '', - validationAction: 'error', - validationLevel: 'strict', - isChanged: true, - syntaxError: { message: 'Syntax Error!' }, - error: null, - }); - }); - }); }); }); diff --git a/packages/compass-schema-validation/src/modules/validation.ts b/packages/compass-schema-validation/src/modules/validation.ts index 5aec4caa407..1b18f362ce2 100644 --- a/packages/compass-schema-validation/src/modules/validation.ts +++ b/packages/compass-schema-validation/src/modules/validation.ts @@ -75,23 +75,13 @@ interface ValidationLevelChangedAction { validationLevel: ValidationLevel; } -/** - * Syntax error occurred action name. - */ -export const SYNTAX_ERROR_OCCURRED = `${PREFIX}/SYNTAX_ERROR_OCCURRED` as const; -interface SyntaxErrorOccurredAction { - type: typeof SYNTAX_ERROR_OCCURRED; - syntaxError: null | { message: string }; -} - export type ValidationAction = | ValidatorChangedAction | ValidationCanceledAction | ValidationSaveFailedAction | ValidationFetchedAction | ValidationActionChangedAction - | ValidationLevelChangedAction - | SyntaxErrorOccurredAction; + | ValidationLevelChangedAction; export interface Validation { validator: string; @@ -178,18 +168,6 @@ const changeValidator = ( }; }; -/** - * Sets syntax error. - */ -const setSyntaxError = ( - state: ValidationState, - action: SyntaxErrorOccurredAction -): ValidationState => ({ - ...state, - isChanged: true, - syntaxError: action.syntaxError, -}); - /** * Set validation. */ @@ -291,7 +269,6 @@ const MAPPINGS: { [VALIDATION_SAVE_FAILED]: setError, [VALIDATION_ACTION_CHANGED]: changeValidationAction, [VALIDATION_LEVEL_CHANGED]: changeValidationLevel, - [SYNTAX_ERROR_OCCURRED]: setSyntaxError, }; /** @@ -372,16 +349,6 @@ export const validationSaveFailed = (error: { error, }); -/** - * Action creator for syntax error occurred events. - */ -export const syntaxErrorOccurred = ( - syntaxError: null | { message: string } -): SyntaxErrorOccurredAction => ({ - type: SYNTAX_ERROR_OCCURRED, - syntaxError, -}); - export const fetchValidation = (namespace: { database: string; collection: string;