Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSSOM sssupport #108

Closed
6 tasks
kevinschaper opened this issue May 9, 2023 · 7 comments
Closed
6 tasks

Add SSSOM sssupport #108

kevinschaper opened this issue May 9, 2023 · 7 comments

Comments

@kevinschaper
Copy link
Member

Let's do our mapping with Koza.

We need to leave the original mapping support code available, since it's

Config changes:

  • Add config option for list of SSSOM mapping files
  • Add config option for ordered list of preferred prefixes

SSSOM reader:

  • Add a SSSOM reader to bring the files and load them into memory (probably using SSSOM-py?). It probably could be filtered on load to only hang on to rows that include the preferred ID prefixes

SSSOM utils:

  • If SSSOM-py doesn't already do this, add a function that takes the preferred ID list and brings returns the mapped ID

kgx writer:

  • If SSSOM is configured for the ingest, add original_subject/original_object fields to the header
  • use the sssom utils to populate subject, object, original_subject, original_object

Note: I had been thinking of writing both un-mapped output and separately write the mapped files, but that feels like kind of a waste of space, since you can (fairly) easily rewind the mapping logic

@matentzn
Copy link
Member

sssupport.

🐍

Is this about rewiring at ingest time?

@kevinschaper
Copy link
Member Author

@matentzn yeah, I wasn't sure if it should happen in koza, kgx, or a standalone tool and I got excited about koza support because we don't need to iterate over all the rows a second time.

(Plus also that ideally koza and kgx should probably both be able to rewire based on a sssom file/df)

@matentzn
Copy link
Member

OK cool. So the rewire code will leave in a single module that is shared by both tools, or will this be duplicated? I would be interested to review that code once it is there, just so you know if you would like another pair of eyes on it!

@sierra-moxon
Copy link
Member

@kevinschaper
Copy link
Member Author

Is that for applying mappings to rewire edges or transforming the SSSOM itself into other formats?

@hrshdhgd
Copy link
Collaborator

I don't recall writing this code.

@glass-ships glass-ships mentioned this issue May 30, 2023
6 tasks
@glass-ships
Copy link
Collaborator

see #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants