From 3eb7a78914241ca25d24e4015d83f7d4de3d46a9 Mon Sep 17 00:00:00 2001 From: matt-heery Date: Mon, 12 Aug 2024 16:07:18 +0100 Subject: [PATCH 1/3] unit tests --- pydbtools/utils.py | 2 +- tests/test_utils.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pydbtools/utils.py b/pydbtools/utils.py index 7284407..7f6be7f 100644 --- a/pydbtools/utils.py +++ b/pydbtools/utils.py @@ -60,7 +60,7 @@ None, ), ( - r"[A-Za-z0-9]+:GitHubActions", # GitHub action for e2e + r"^githubactions$", # GitHub action for e2e None, ), ] diff --git a/tests/test_utils.py b/tests/test_utils.py index 5e03235..8140d33 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -43,6 +43,7 @@ def test_pyproject_toml_matches_version(): ("3f7f9e93-airflow_prod_role_name", "airflow_prod_role_name"), ("3f7f9e9-airflow_prod_role_name", "airflow_prod_role_name"), ("abcde:airflow_prod_role_name", "airflow_prod_role_name"), + ("abcde:GitHubActions", "githubactions"), ], ) def test_clean_user_id(test_input, expected): From 4b4e7972b2a4c2ae02ef33160aee9cecfa2289d8 Mon Sep 17 00:00:00 2001 From: matt-heery Date: Mon, 12 Aug 2024 16:09:32 +0100 Subject: [PATCH 2/3] update version and changelo --- CHANGELOG.md | 4 ++++ pydbtools/__init__.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 24c2652..69f61de 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## v5.6.2 - 2024-07-31 + +- fix and unit test additional rule to recognise aws roles coming from github actions ([#136](https://github.com/moj-analytical-services/pydbtools/pull/136)) + ## v5.6.1 - 2024-07-31 - fix failing mkdocs build ([#135](https://github.com/moj-analytical-services/pydbtools/pull/135)) diff --git a/pydbtools/__init__.py b/pydbtools/__init__.py index 9f8a0a1..f67430e 100644 --- a/pydbtools/__init__.py +++ b/pydbtools/__init__.py @@ -31,4 +31,4 @@ ) from .utils import s3_path_join # noqa: F401 -__version__ = "5.6.1" +__version__ = "5.6.2" From 872512a6f94bc549462dffaddb1aa092ef0df02d Mon Sep 17 00:00:00 2001 From: matt-heery Date: Mon, 12 Aug 2024 16:13:00 +0100 Subject: [PATCH 3/3] didnt press save --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index ac0100d..f8c9686 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,7 +1,7 @@ [tool] [tool.poetry] name = "pydbtools" -version = "5.6.1" +version = "5.6.2" description = "A python package to query data via amazon athena and bring it into a pandas df using aws-wrangler." license = "MIT" authors = ["Karik Isichei "]