On empty dataframes, methods (that go through __getattribute__
) default to pandas
#4418
Labels
Code Quality 💯
Improvements or issues to improve quality of codebase
Internals
Internal modin functionality
P2
Minor bugs or low-priority feature requests
However, magic methods do not pass through function
__getattribute__
(for example:__setitem__
). Should we do a similar check for them?Also, for some functions, code branches remained for cases where one of several axes has zero length (for example:
insert
). In the current implementation, these code paths are unreachable for the thread of execution. I think that they need to be removed. @modin-project/modin-core what do you think about this?Links:
modin/modin/pandas/base.py
Line 3825 in 0ab04e1
modin/modin/pandas/dataframe.py
Line 1136 in 0ab04e1
The text was updated successfully, but these errors were encountered: