Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurelius: avro_from_df should handle case of missing values #53

Open
steadyfish opened this issue May 17, 2018 · 0 comments
Open

Aurelius: avro_from_df should handle case of missing values #53

steadyfish opened this issue May 17, 2018 · 0 comments

Comments

@steadyfish
Copy link

Currently, avro_from_df function just takes data type of the column and converts it to corresponding PFA type. It'd help if this function handles the case where a column has some missing values.

Minimal reproducible example:

a = data.frame(col1 = c(1, 2), col2 = c(1.234565, NA))
avro_from_df(a)

I'd expect col2 to be of type avro_union(avro_double, avro_null) and not avro_double.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant