From 9b1929e68f9d7fc083ef7be0a0a9e47becf9959c Mon Sep 17 00:00:00 2001 From: Oleksandr Dzhychko Date: Wed, 3 Jan 2024 15:05:09 +0100 Subject: [PATCH] feat(model-server)!: Use ENTRYPOINT instead of CMD in the provided Docker image > You can use the exec form of ENTRYPOINT to set fairly stable default commands and arguments and then use either form of CMD to set additional defaults that are more likely to be changed. See. https://docs.docker.com/engine/reference/builder/#exec-form-entrypoint-example Using a ENTRYPOINT in model-server docker container makes passing arguments easier. For example, `docker run --rm -p 28101:28101 -it modelix/model-server ./run-model-server.sh -inmemory` would be simplified to `docker run --rm -p 28101:28101 -it modelix/model-server -inmemory` This is a breaking change, because the previous ENTRYPOINT was the default `ENTRYPOINT ["/bin/sh", "-c"]`. --- model-server/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model-server/Dockerfile b/model-server/Dockerfile index 081b0d3489..b633010249 100644 --- a/model-server/Dockerfile +++ b/model-server/Dockerfile @@ -4,4 +4,4 @@ EXPOSE 28101 COPY run-model-server.sh /usr/modelix-model/ COPY build/dependency-libs/ /usr/modelix-model/model-server/build/libs/ COPY build/libs/ /usr/modelix-model/model-server/build/libs/ -CMD ["./run-model-server.sh"] +ENTRYPOINT ["./run-model-server.sh"]