Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of selectedSegmentIds #61

Open
K-Meech opened this issue Jul 15, 2021 · 4 comments
Open

Clarification of selectedSegmentIds #61

K-Meech opened this issue Jul 15, 2021 · 4 comments

Comments

@K-Meech
Copy link
Contributor

K-Meech commented Jul 15, 2021

It would be useful to add a bit of clarification as to what a 'segment id' is here: https://github.com/mobie/mobie.github.io/blob/master/schema/view.schema.json#L197

@constantinpape Am I right that it is "sourceName;timePoint;label_id";, like here: https://github.com/mobie/platybrowser-datasets/blob/spec-v2/data/1.0.1/dataset.json#L2927? (I need to update the bookmark saving to reflect this too)

@constantinpape
Copy link
Contributor

@constantinpape Am I right that it is "sourceName;timePoint;label_id";, like here: https://github.com/mobie/platybrowser-datasets/blob/spec-v2/data/1.0.1/dataset.json#L2927? (I need to update the bookmark saving to reflect this too)

Yes, that's correct. Feel free to expand the description string to describe it better.

@K-Meech
Copy link
Contributor Author

K-Meech commented Sep 23, 2021

@constantinpape - just wanted to check, what's the format for the selectedAnnotationIds in sourceAnnotationDisplay? https://github.com/mobie/mobie.github.io/blob/master/schema/view.schema.json#L286 Is it sourceName;annotationId? Thanks!

@constantinpape
Copy link
Contributor

@K-Meech it's timePoint;annotationId (which should be added as documentation...)

@K-Meech
Copy link
Contributor Author

K-Meech commented Sep 23, 2021

Ok great! I can add lines to the docs for both of these :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants