Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] subplot parameter in plot_connectivity_circle is supposed to be deprecated #255

Open
tsbinns opened this issue Nov 11, 2024 · 5 comments · May be fixed by #257
Open

[DOC] subplot parameter in plot_connectivity_circle is supposed to be deprecated #255

tsbinns opened this issue Nov 11, 2024 · 5 comments · May be fixed by #257

Comments

@tsbinns
Copy link
Collaborator

tsbinns commented Nov 11, 2024

According to the docs, the subplot parameter of plot_connectivity_circle is Deprecated: will be removed in version 0.5.

Can this just be removed now, or is a new deprecation cycle required?

@drammock
Copy link
Member

Ok to remove late with no additional warning

@tsbinns tsbinns linked a pull request Nov 12, 2024 that will close this issue
@RohitP2005
Copy link

@drammock can i work on this ? might be a good issue for me

@drammock
Copy link
Member

@drammock can i work on this ? might be a good issue for me

Sure, feel free to open a pull request @RohitP2005!

@tsbinns
Copy link
Collaborator Author

tsbinns commented Dec 21, 2024

This is addressed in #257, it's just pending a review.

@RohitP2005
Copy link

@tsbinns okay then , I will leave it to u guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants