Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group vs group_mask #126

Open
mmagnuski opened this issue Oct 2, 2023 · 1 comment
Open

group vs group_mask #126

mmagnuski opened this issue Oct 2, 2023 · 1 comment

Comments

@mmagnuski
Copy link
Owner

I've moved over group from sarna, but existing borsar group_mask looks more efficient. I'll have to take a look and see if some functionality is missing from group_mask so that group could be removed.
@mmagnuski
Copy link
Owner Author

group_mask is more efficient for larger arrays and produces identical output. Would just need return_slice option that returns a list of slices, instead of N x 2 start, stop index array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmagnuski