Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend alignment issues #18

Open
joeyklee opened this issue May 9, 2019 · 2 comments · May be fixed by #190
Open

Frontend alignment issues #18

joeyklee opened this issue May 9, 2019 · 2 comments · May be fixed by #190
Labels
content

Comments

@joeyklee
Copy link
Contributor

joeyklee commented May 9, 2019

Just some notes on things to fix regarding alignment:

homepage - discover section

Screen Shot 2019-05-09 at 11 54 07
@wenqili
Copy link
Member

wenqili commented May 10, 2019

Simple fix: process all the images here to the same ratio.

All the images are embedded as <img> tag instead of a <div> background image for accessibility reason. Set <img> to the same ratio from front end might cause the image distortion.

@joeyklee
Copy link
Contributor Author

@wenqili - yes, let's do it this way. Handling image resizing etc etc can be a pain. Thanks for the tip!

@lindapaiste lindapaiste linked a pull request Jun 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to gatsby-plugin-image lindapaiste/ml5-website
2 participants
@joeyklee @wenqili