Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI output of algorithm is not the same as AlgorithmResult #112

Closed
RamSaw opened this issue Aug 1, 2018 · 2 comments
Closed

UI output of algorithm is not the same as AlgorithmResult #112

RamSaw opened this issue Aug 1, 2018 · 2 comments

Comments

@RamSaw
Copy link
Contributor

RamSaw commented Aug 1, 2018

The problem occurred on ant_modified project from dataset. CCDA has found 12 refactorings and returned them in AlgorithmResult instance. But in UI appeared not all 12. Furthermore the ui output for CCDA is not deterministic too (see #111). But it could be because of #111. Probably the problem is as follows: after getting AlgorithmResult it can be filtered (for example remove from result all refactorings with abstract classes) and also AlgorithmResult instances are combined and perhaps even if we have run only 1 algorithm it still influence on ui output.

@RamSaw
Copy link
Contributor Author

RamSaw commented Aug 6, 2018

Reason: ClassRefactoringPanel.java line 61. Method filter is called, it remains only isMovable methods.

@RamSaw
Copy link
Contributor Author

RamSaw commented Aug 6, 2018

Possible solution: leave it as it is now, because it is closer to UI rather than to algorithm execution part. Now UI suggests functionality for Move Method Refactoring and it should be done automatically. But Overriding methods cannot be moved automatically that is why we need to filter it. But if we want to show them to user it will be easy to add this functionality.

@RamSaw RamSaw closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant