Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameterized to requirements.txt (or to test-requirements.txt) #221

Closed
ancieg opened this issue Jul 25, 2024 · 0 comments · Fixed by #222
Closed

Add parameterized to requirements.txt (or to test-requirements.txt) #221

ancieg opened this issue Jul 25, 2024 · 0 comments · Fixed by #222
Assignees
Labels
Milestone

Comments

@ancieg
Copy link

ancieg commented Jul 25, 2024

When I run python3 -m unittest (after installing dependencies listed in requirements.txt), I encounter the following errors:

======================================================================
ERROR: test.test_block_token (unittest.loader._FailedTest.test.test_block_token)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_block_token
Traceback (most recent call last):
  File "/usr/lib64/python3.12/unittest/loader.py", line 394, in _find_test_path
    module = self._get_module_from_name(name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/unittest/loader.py", line 337, in _get_module_from_name
    __import__(name)
  File "/usr/src/RPM/BUILD/python3-module-mistletoe-1.4.0/test/test_block_token.py", line 4, in <module>
    from parameterized import parameterized
ModuleNotFoundError: No module named 'parameterized'


======================================================================
ERROR: test.test_contrib.test_pygments_renderer (unittest.loader._FailedTest.test.test_contrib.test_pygments_renderer)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_contrib.test_pygments_renderer
Traceback (most recent call last):
  File "/usr/lib64/python3.12/unittest/loader.py", line 394, in _find_test_path
    module = self._get_module_from_name(name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/unittest/loader.py", line 337, in _get_module_from_name
    __import__(name)
  File "/usr/src/RPM/BUILD/python3-module-mistletoe-1.4.0/test/test_contrib/test_pygments_renderer.py", line 5, in <module>
    from parameterized import parameterized
ModuleNotFoundError: No module named 'parameterized'


======================================================================
ERROR: test.test_html_renderer (unittest.loader._FailedTest.test.test_html_renderer)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_html_renderer
Traceback (most recent call last):
  File "/usr/lib64/python3.12/unittest/loader.py", line 394, in _find_test_path
    module = self._get_module_from_name(name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/unittest/loader.py", line 337, in _get_module_from_name
    __import__(name)
  File "/usr/src/RPM/BUILD/python3-module-mistletoe-1.4.0/test/test_html_renderer.py", line 4, in <module>
    from parameterized import parameterized
ModuleNotFoundError: No module named 'parameterized'


======================================================================
ERROR: test.test_latex_renderer (unittest.loader._FailedTest.test.test_latex_renderer)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_latex_renderer
Traceback (most recent call last):
  File "/usr/lib64/python3.12/unittest/loader.py", line 394, in _find_test_path
    module = self._get_module_from_name(name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/unittest/loader.py", line 337, in _get_module_from_name
    __import__(name)
  File "/usr/src/RPM/BUILD/python3-module-mistletoe-1.4.0/test/test_latex_renderer.py", line 2, in <module>
    from parameterized import parameterized
ModuleNotFoundError: No module named 'parameterized'


----------------------------------------------------------------------
Ran 199 tests in 0.035s

FAILED (errors=4)

I think that is a good idea to add parameterized to requirements.txt (or to test-requirements.txt).

pbodnar added a commit that referenced this issue Jul 27, 2024
Define all the needed requirements and the
test command, so that running `tox` runs the
unit tests and runs them successfully.

Also simplify the CI workflow by using both
requirements files - exactly how tox does it.

Fixes #220 and #221.
@pbodnar pbodnar linked a pull request Jul 27, 2024 that will close this issue
@pbodnar pbodnar added this to the 1.5.0 milestone Jul 27, 2024
@pbodnar pbodnar added the tests label Jul 27, 2024
@pbodnar pbodnar self-assigned this Jul 27, 2024
pbodnar added a commit that referenced this issue Jul 29, 2024
Define all the needed requirements and the
test command, so that running `tox` runs the
unit tests and runs them successfully.

Also simplify the CI workflow by using both
requirements files - exactly how tox does it.

Fixes #220 and #221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants