From ff8c3f746ba437180065a19ce9dbe4e67abc3531 Mon Sep 17 00:00:00 2001 From: izturn <44051386+izturn@users.noreply.github.com> Date: Fri, 27 May 2022 20:53:27 +0800 Subject: [PATCH] fix crash when opts is nil (#90) Signed-off-by: Gang Liu --- client.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client.go b/client.go index 8fcdf5c0..6e9d52c2 100644 --- a/client.go +++ b/client.go @@ -107,7 +107,7 @@ func newClient(options *Options, clientGetter genericclioptions.RESTClientGetter registryClient, err := registry.NewClient( registry.ClientOptDebug(settings.Debug), registry.ClientOptCredentialsFile(settings.RegistryConfig), - ) + ) if err != nil { return nil, err } @@ -389,7 +389,7 @@ func (c *HelmClient) upgrade(ctx context.Context, spec *ChartSpec, opts *Generic upgradedRelease, upgradeErr := client.RunWithContext(ctx, spec.ReleaseName, helmChart, values) if upgradeErr != nil { - if upgradedRelease != nil && opts.RollBack != nil { + if upgradedRelease != nil && opts != nil && opts.RollBack != nil { return nil, opts.RollBack.RollbackRelease(spec) } return nil, upgradeErr