You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It has been quite some time since the entire RHEL codebase has been reviewed to ensure that tests with similar focuses (like all tests for audit rules, or all tests for kernel settings), many of which are written by different authors, are consistent in their approach. We need to take a read-through of each control to ensure that similar controls have similar test code, and ensure that the common approach covers all edge cases.
The text was updated successfully, but these errors were encountered:
I created this PR (#47) without making any changes to address either the 4th or last items here. It seems to me that it would be more readable to allow either .reject or .select just for readability's sake rather than requiring an unnecessary negation. Also, there seems to be a lot of instances where both are used.
Also, with regards to the last item, I could only find a few instances where the ini resource is used, but they either didn't depend on any commands or just used cat, which I don't think should require an explicit check for if it is installed (even if cat doesn't exist, it seems like the test will fail and not give a false positive).
It has been quite some time since the entire RHEL codebase has been reviewed to ensure that tests with similar focuses (like all tests for audit rules, or all tests for kernel settings), many of which are written by different authors, are consistent in their approach. We need to take a read-through of each control to ensure that similar controls have similar test code, and ensure that the common approach covers all edge cases.
The text was updated successfully, but these errors were encountered: