Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph arrow should give feedback when clicked. #16

Open
mitra42 opened this issue Feb 6, 2025 · 4 comments
Open

Graph arrow should give feedback when clicked. #16

mitra42 opened this issue Feb 6, 2025 · 4 comments
Milestone

Comments

@mitra42
Copy link
Owner

mitra42 commented Feb 6, 2025

Response of clicking left arrow on graph is slow

Should change e.g. to sandglass - and then back when data loaded

Also need visual indication if no data sets received as Axis doesnt (maybe at least put a number of days beneath)

@mitra42
Copy link
Owner Author

mitra42 commented Feb 8, 2025

Strategy

  • UX triggered from MqttGraph.graphnavleft
  • This calls MG.addDataFrom
  • which fetches file in paralel over each dataset then has a console line ("XXX72 done all")
    -In MG.addDataFrom
    • if couter is 0 - change to animated gif,
    • increment counter
  • after the async
    dec counter
    if 0 change to static gif

Note that when new dataset added it uses graphNavLeftFIlenames which calls GD.addDataFrom and I think can ignore this.

@mitra42
Copy link
Owner Author

mitra42 commented Feb 9, 2025

Works - not sure its sufficient to account for lines with no back-history because in most cases its very quick

@mitra42
Copy link
Owner Author

mitra42 commented Feb 9, 2025

Idea .... if the data comes in empty, add a single point with a null

MqttGraph.state.dateFrom is the target first date, can get current date from existing data as done in MqttTopic.addDataFrom

Strategy - pass dateFrom down through chain to MT.addDataFrom OR maybe can get it at MT level

Done .... now expands axis and adds dashes to previous data

@mitra42
Copy link
Owner Author

mitra42 commented Feb 9, 2025

Should also add the reverse - to trim back down
Strategy

  • icon like left arrow
  • goes to graphnavright
  • changes dateFrom in other direction - but not into future.
  • loops thru children (Datasets) passing new date
  • each child removes all date from before that date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant