Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightDescription missing hardware_number for VisualPinball.Engine platform #1586

Open
jsm174 opened this issue Jul 14, 2021 · 2 comments
Open

Comments

@jsm174
Copy link

jsm174 commented Jul 14, 2021

While working on dependency updates for VisualPinball.Engine.Mpf, we noticed an exception while parsing lights when a user presses Get Machine Description.

Coils and switches currently have a number node. Lights seem to be missing a number node:

message SwitchDescription {
string name = 1;
string hardware_number = 2;
string switch_type = 3; // NO or NC
}
message CoilDescription {
string name = 1;
string hardware_number = 2;
}
message LightDescription {
string name = 1;
string hardware_channel_number = 2;
string hardware_channel_color = 3;
}

Other examples in the repo reference number for lights as well:

#config_version=5
lights:
light_1:
number: 1
tags: playfield, light_group_1
light_2:
number: 2
tags: playfield, light_group_1
light_3:
number: 3
tags: playfield, light_group_1

@jsm174
Copy link
Author

jsm174 commented Nov 29, 2021

Hello again. We are about to release a new version of VisualPinball.Engine.Mpf.
@jabdoa2 - Any thoughts on this issue?

@jabdoa2
Copy link
Collaborator

jabdoa2 commented Nov 29, 2021

Sorry I missed it. I can try to add something this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants