Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation and Tests Failing #91

Open
PizieDust opened this issue Jul 11, 2023 · 1 comment · May be fixed by #93
Open

Compilation and Tests Failing #91

PizieDust opened this issue Jul 11, 2023 · 1 comment · May be fixed by #93

Comments

@PizieDust
Copy link

Running dune runtest or dune build reports the following errors:

File "src/fat.ml", line 1:
Error: The implementation src/fat.pp.ml
       does not match the interface src/.fat_filesystem.objs/byte/fat.cmi:
       ... ...
       The value `get_partial' is required but not provided
       File "src/mirage_kv.mli", line 140, characters 2-98:
         Expected declaration
       In module KV_RO:
       The value `size' is required but not provided
       File "src/mirage_kv.mli", line 175, characters 2-60:
         Expected declaration
@PizieDust
Copy link
Author

PizieDust commented Jul 11, 2023 •
edited
Loading

Seems this has to do with the mirage-kv package.
We have to update our ocaml-fat library to implement the get_partial and size from the mirage_kv interface RO module perhaps

@PizieDust PizieDust linked a pull request Jul 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement functions to comform with mirage.kv_ro interface PizieDust/ocaml-fat
1 participant
@PizieDust