Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 When we retire a Tool release, uninstall it from users namespaces #6705

Open
4 tasks
michaeljcollinsuk opened this issue Feb 4, 2025 · 0 comments
Open
4 tasks
Assignees
Labels

Comments

@michaeljcollinsuk
Copy link
Contributor

User Story

As a AP engineer
I want to remove access to old tool releases
So that we reduce our maintenance overhead

Value / Purpose

Currently, even after a tool has been retired by the AP (making it inaccessible via Control Panel), if a user has it deployed they can continue to use it by hitting the direct tool URL.
If we uninstall a releases from all users namespaces when we retire the Tool in control panel, it will solve this issue and stop users being able to access old tools.

Useful Contacts

No response

User Types

No response

Hypothesis

No response

Proposal

When marking a tool as retired (or deleting it) via the control panel, go through all users that currently have the tool installed and run the helm uninstall command to remove it. This will look like:

  • Mark Tool as retired via Control Panel. This functionality already exists.
  • Loop through all ToolDeployment marked as active and call the uninstall() method. This is new functionality.

TBC
For performance reasons, we may want to use a celery task to handle the uninstalls

Additional Information

A DB record between users and their deployed Tool was added in a latest Control Panel release.

Definition of Done

  • Code updated
  • Unit tests added
  • Deployed to dev and tested
  • Deployred to prod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

1 participant