Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finufft Tests are very slow #244

Open
paquiteau opened this issue Mar 3, 2025 · 1 comment
Open

Finufft Tests are very slow #244

paquiteau opened this issue Mar 3, 2025 · 1 comment
Assignees
Labels
CI nufft-backend Issues regarding NUFFT backend support tests

Comments

@paquiteau
Copy link
Member

paquiteau commented Mar 3, 2025

On the local runner instance it seems that the test using finufft has a backend are running forever (more than 1hour)

to reproduce locally I ran

pytest --backend=finufft --ref=finufft --durations=10 --cov

NB: the durations arg is there to track how much time each test took

============================ slowest 10 durations ============================
69.51s call     tests/operators/test_offres_exp_approx.py::test_zmap_coeff[complex3D-numpy]
68.85s call     tests/operators/test_offres_exp_approx.py::test_b0map_coeff[real3D-numpy]
37.10s call     tests/operators/test_offres_exp_approx.py::test_zmap_coeff[complex3D-torch-cpu]
36.16s call     tests/operators/test_offres_exp_approx.py::test_b0map_coeff[real3D-torch-cpu]
17.34s call     tests/test_ndft.py::test_ndft_implicit1[grid3D]
13.86s call     tests/operators/test_offres_exp_approx.py::test_b0map_coeff[real3D-torch-gpu]
12.18s call     tests/operators/test_offres_exp_approx.py::test_b0map_coeff[real3D-cupy]
11.22s call     tests/operators/test_offres_exp_approx.py::test_zmap_coeff[complex3D-cupy]
9.25s call     tests/test_ndft.py::test_ndft_implicit2[grid3D]
7.65s call     tests/operators/test_interfaces.py::test_interface_lipschitz[random3D-finufft]

Overall, it took 10 minutes to run this command, way more reasonable than the 1h30 on the CI

@paquiteau paquiteau self-assigned this Mar 3, 2025
@paquiteau paquiteau added nufft-backend Issues regarding NUFFT backend support tests CI labels Mar 3, 2025
@paquiteau
Copy link
Member Author

paquiteau commented Mar 3, 2025

From offline discussion in order to make the CI even faster:

  • Extract the offres_ex_approx.py tests to not be runned with operators (They don't call any nufft actually)
  • filter test_examples (e.g with commit head line)
  • run examples tes in parallel (using xdist)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI nufft-backend Issues regarding NUFFT backend support tests
Projects
None yet
Development

No branches or pull requests

1 participant