Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration of the linter #88

Open
lionelkusch opened this issue Dec 23, 2024 · 2 comments
Open

Configuration of the linter #88

lionelkusch opened this issue Dec 23, 2024 · 2 comments
Labels
coding style question regarding formatting and declaration of functions management of project question regarding the policy of the project

Comments

@lionelkusch
Copy link
Collaborator

The actual linter is Black. There is not a configuration provided to it.
We need to check if it's enough or not?

For the future, it can be interesting to look at Ruff for being compatible with scitkit-learn.
@lionelkusch lionelkusch added management of project question regarding the policy of the project coding style question regarding formatting and declaration of functions labels Dec 23, 2024
@Remi-Gau
Copy link
Collaborator

+1 for ruff: also because it gives you single tool to replace black, isort and whole bunch of other things...

@lionelkusch
Copy link
Collaborator Author 

          No 'X' uppercase is an sklearn convention, we need to stick to it.

Originally posted by @bthirion in #128 (comment)

For the configuration of ruff, we should look at the sklearn configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coding style question regarding formatting and declaration of functions management of project question regarding the policy of the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Remi-Gau @lionelkusch