Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homogenisation of docstring for the declaration of parameters #135

Open
lionelkusch opened this issue Jan 20, 2025 · 5 comments
Open

homogenisation of docstring for the declaration of parameters #135

lionelkusch opened this issue Jan 20, 2025 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@lionelkusch
Copy link
Collaborator

For the moment, there are multiple ways to declare parameters:

version 1:
name : type, optional (default=default_value)
description
version 2:
name : type, default=default_value
description

What is the best way?
Do we indicate if a parameter is optional or not?

@lionelkusch lionelkusch added the documentation Improvements or additions to documentation label Jan 20, 2025
@bthirion
Copy link
Contributor

The second one is the right one. We're currently propagating it throughout Nilearn.

@lionelkusch
Copy link
Collaborator Author

Do you want to apply it now, i.e. in the same as the model PR or to create a PR after just this point?

@bthirion
Copy link
Contributor

Do it in several PRs to keep them light. It's a good task when you're tired ;-)

@lionelkusch
Copy link
Collaborator Author

ok. Thank you for the advice.

@lionelkusch
Copy link
Collaborator Author

File to refactors:

  • ada_svr
  • clustered_inference
  • cpi
  • dcrt
  • desparsified_lasso
  • Dnn_learner
  • ensemble_clustred_inference
  • gaussian_knockoff
  • knockoff
  • loco
  • permutation_importance
  • permutation_test
  • RandomForestModified
  • empirical_threshold
  • utils/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants