Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Skip loading pk index for sorted segment in loader #39438

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #39437

Related to #39339
Previous PR #39389 only skips append index into segment

Also related to #39428

Related to milvus-io#39339
Previous PR milvus-io#39389 only skips append index into segment

Also related to milvus-io#39428

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jan 20, 2025
@sre-ci-robot sre-ci-robot requested review from aoiasd and yah01 January 20, 2025 06:32
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 20, 2025
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 20, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@yanliang567 yanliang567 added this to the 2.5.4 milestone Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (8c35064) to head (7af633d).
Report is 7 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment.go 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39438      +/-   ##
==========================================
- Coverage   80.99%   80.97%   -0.02%     
==========================================
  Files        1404     1404              
  Lines      197570   197581      +11     
==========================================
- Hits       160013   159998      -15     
- Misses      31931    31958      +27     
+ Partials     5626     5625       -1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.49% <ø> (ø)
Go 82.94% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 66.16% <0.00%> (-0.74%) ⬇️

... and 28 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 20, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 20, 2025
@sre-ci-robot sre-ci-robot merged commit 8e2e828 into milvus-io:2.5 Jan 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants