-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.5] Skip loading pk index for sorted segment in loader #39438
Conversation
Related to milvus-io#39339 Previous PR milvus-io#39389 only skips append index into segment Also related to milvus-io#39428 Signed-off-by: Congqi Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia go-sdk check failed, comment |
rerun go-sdk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39438 +/- ##
==========================================
- Coverage 80.99% 80.97% -0.02%
==========================================
Files 1404 1404
Lines 197570 197581 +11
==========================================
- Hits 160013 159998 -15
- Misses 31931 31958 +27
+ Partials 5626 5625 -1
|
@congqixia go-sdk check failed, comment |
rerun go-sdk |
Cherry pick from master
pr: #39437
Related to #39339
Previous PR #39389 only skips append index into segment
Also related to #39428