Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleted the sealed segment data accidentally #39422

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Jan 19, 2025

issue:#39333
pr: #39421

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Jan 19, 2025
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby January 19, 2025 18:56
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 19, 2025
Copy link
Contributor

mergify bot commented Jan 19, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (57bcb1b) to head (41f675e).
Report is 9 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/datacoord/services.go 40.00% 2 Missing and 1 partial ⚠️
internal/datacoord/segment_manager.go 85.71% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39422      +/-   ##
==========================================
- Coverage   81.00%   80.97%   -0.04%     
==========================================
  Files        1404     1404              
  Lines      197579   197581       +2     
==========================================
- Hits       160058   159998      -60     
- Misses      31900    31963      +63     
+ Partials     5621     5620       -1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.49% <ø> (-0.01%) ⬇️
Go 82.94% <73.68%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/segment_manager.go 87.66% <85.71%> (+0.19%) ⬆️
internal/datacoord/services.go 85.49% <40.00%> (+0.12%) ⬆️

... and 33 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 20, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Jan 20, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 20, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 20, 2025
@czs007
Copy link
Collaborator Author

czs007 commented Jan 20, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 20, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Jan 20, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 20, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Jan 20, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 20, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit 964000f into milvus-io:2.5 Jan 20, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants