Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.5]Add schema update time verification for insert and upsert to use cache #39382

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from
Open

enhance: [2.5]Add schema update time verification for insert and upsert to use cache #39382

wants to merge 2 commits into from
+288 −150

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Jan 17, 2025 •
edited
Loading

enhance: Add schema update time verification for insert and upsert to use cache
issue: #39093
Related to pr: #39096

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file labels Jan 17, 2025
@JsDove JsDove mentioned this pull request Jan 17, 2025
Open
1 task
@mergify mergify bot added the dco-passed DCO check passed. label Jan 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Jan 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.16418% with 22 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (6f9f840) to head (4c218cb).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/task_insert.go 50.00% 6 Missing and 2 partials ⚠️
internal/proxy/task_upsert.go 50.00% 6 Missing and 2 partials ⚠️
internal/rootcoord/alter_collection_task.go 50.00% 4 Missing ⚠️
pkg/util/merr/utils.go 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39382   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files        1404     1404           
  Lines      197578   197637   +59     
=======================================
+ Hits       160047   160100   +53     
- Misses      31916    31926   +10     
+ Partials     5615     5611    -4
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.47% <ø> (ø)
Go 82.97% <67.16%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/metastore/model/collection.go 84.51% <100.00%> (+0.41%) ⬆️
internal/proxy/impl.go 83.85% <100.00%> (+<0.01%) ⬆️
internal/proxy/meta_cache.go 90.66% <100.00%> (+0.02%) ⬆️
internal/proxy/task.go 80.65% <100.00%> (+0.01%) ⬆️
internal/rootcoord/create_collection_task.go 90.47% <100.00%> (+0.01%) ⬆️
internal/rootcoord/root_coord.go 90.14% <100.00%> (+<0.01%) ⬆️
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 84.19% <75.00%> (-0.09%) ⬇️
internal/rootcoord/alter_collection_task.go 53.30% <50.00%> (-0.11%) ⬇️
internal/proxy/task_insert.go 72.99% <50.00%> (-1.67%) ⬇️
... and 1 more

... and 27 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2025
@JsDove
Copy link
Contributor Author

JsDove commented Jan 17, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 17, 2025

rerun go-sdk

@mergify mergify bot added ci-passed and removed ci-passed labels Jan 17, 2025
liliu-z
liliu-z reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JsDove, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 17, 2025

rerun go-sdk

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 17, 2025
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 17, 2025
@JsDove
Copy link
Contributor Author

JsDove commented Jan 17, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot removed the ci-passed label Jan 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 17, 2025

rerun go-sdk

@JsDove
Copy link
Contributor Author

JsDove commented Jan 17, 2025

run ut

@mergify mergify bot added the ci-passed label Jan 17, 2025
@JsDove
Copy link
Contributor Author

JsDove commented Jan 18, 2025

rerun ut

@mergify mergify bot removed the ci-passed label Jan 18, 2025
@JsDove
Copy link
Contributor Author

JsDove commented Jan 19, 2025

rerun ut

@JsDove
Copy link
Contributor Author

JsDove commented Jan 19, 2025

run ut

1 similar comment
@JsDove
Copy link
Contributor Author

JsDove commented Jan 19, 2025

run ut

@JsDove
Copy link
Contributor Author

JsDove commented Jan 19, 2025

rerun ut

@mergify mergify bot added the ci-passed label Jan 20, 2025
JsDove added 2 commits January 20, 2025 17:03
@JsDove
Add schema update time verification to insert and upsert so as to use…
65034d7 
… the cache

Signed-off-by: Xianhui.Lin <[email protected]>

fix unitest

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

fix code

Signed-off-by: Xianhui.Lin <[email protected]>

fix test

Signed-off-by: Xianhui.Lin <[email protected]>

fix go test

Signed-off-by: Xianhui.Lin <[email protected]>

add go unitest

Signed-off-by: Xianhui.Lin <[email protected]>

fix unitest error

Signed-off-by: Xianhui.Lin <[email protected]>

fix ut

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

createcollection use creats

Signed-off-by: Xianhui.Lin <[email protected]>

save to etcd

Signed-off-by: Xianhui.Lin <[email protected]>
@JsDove
fix e2e test error
4c218cb 
Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>
@mergify mergify bot removed the ci-passed label Jan 20, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 20, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 20, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 20, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 20, 2025

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliu-z liliu-z liliu-z left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

@czs007 czs007 Awaiting requested review from czs007

Assignees

@liliu-z liliu-z

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JsDove @sre-ci-robot @liliu-z