Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WKAFKA build flag for control cgo(kafka) feature #96

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

congqixia
Copy link
Collaborator

Resolves #95

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Feb 21, 2023
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yah01
Copy link
Member

yah01 commented Feb 21, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Feb 21, 2023
@sre-ci-robot sre-ci-robot merged commit 8a8fb4a into milvus-io:main Feb 21, 2023
@congqixia congqixia deleted the add_wkafka_flag branch August 18, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add build options to exclude CGO part
3 participants