Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: kv returns more entries than wanted #213

Closed
congqixia opened this issue Nov 17, 2023 · 0 comments · Fixed by #214
Closed

[Bug]: kv returns more entries than wanted #213

congqixia opened this issue Nov 17, 2023 · 0 comments · Fixed by #214
Assignees

Comments

@congqixia
Copy link
Collaborator

Current Behavior

Show segment may treat stats log entry as segment
Get with prefix with tailing '/', this '/' will be ignored

Expected Behavior

tailing '/' cannot be ignore for kv operations

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

@congqixia congqixia self-assigned this Nov 17, 2023
congqixia added a commit to congqixia/birdwatcher that referenced this issue Nov 17, 2023
Since `path.Join` will remove tailing slash, the newly added kv
implementation will return some other kv values when prefix need this
tailing slash.

Add a util function to keep this tailing slash and replace all
`path.Join` in kv impl with it

Fix milvus-io#213

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Nov 18, 2023
Since `path.Join` will remove tailing slash, the newly added kv
implementation will return some other kv values when prefix need this
tailing slash.

Add a util function to keep this tailing slash and replace all
`path.Join` in kv impl with it

Fix #213

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant