Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dry mode rootPath check and add force flag #112

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

congqixia
Copy link
Collaborator

Bypass etcd rootPath check when entering dry mode
Add force flag for connect & use command
Fix #111

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Collaborator Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Mar 21, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 21, 2023
@sre-ci-robot sre-ci-robot merged commit ed4fdf3 into milvus-io:main Mar 21, 2023
@congqixia congqixia deleted the dry_mode_force branch March 27, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed kind/bug Something isn't working lgtm look good to me size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cannot enter dry mode since pingEtcd check fails
3 participants