Skip to content

Commit

Permalink
allow some dead code
Browse files Browse the repository at this point in the history
  • Loading branch information
milenkovicm committed Oct 8, 2024
1 parent 22f6bac commit 96c6957
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
8 changes: 8 additions & 0 deletions ballista/scheduler/src/state/execution_graph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,14 @@ impl ExecutionGraph {
self.output_locations.clone()
}

pub fn output_partitions(&self) -> usize {
self.output_partitions
}

pub fn scheduler_id(&self) -> Option<String> {
self.scheduler_id.clone()
}

/// Reset running and successful stages on a given executor
/// This will first check the unresolved/resolved/running stages and reset the running tasks and successful tasks.
/// Then it will check the successful stage and whether there are running parent stages need to read shuffle from it.
Expand Down
12 changes: 12 additions & 0 deletions ballista/scheduler/src/state/execution_graph/execution_stage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,17 @@ pub(crate) struct FailedStage {
pub(crate) partitions: usize,
/// Stage ID of the stage that will take this stages outputs as inputs.
/// If `output_links` is empty then this the final stage in the `ExecutionGraph`
#[allow(dead_code)]
// we definitely need this one but we're not using it currently
pub(crate) output_links: Vec<usize>,
/// `ExecutionPlan` for this stage
pub(crate) plan: Arc<dyn ExecutionPlan>,
/// TaskInfo of each already scheduled tasks. If info is None, the partition has not yet been scheduled
/// The index of the Vec is the task's partition id
pub(crate) task_infos: Vec<Option<TaskInfo>>,
/// Combined metrics of the already finished tasks in the stage, If it is None, no task is finished yet.
#[allow(dead_code)]
// we definitely need this one but we're not using it currently
pub(crate) stage_metrics: Option<Vec<MetricsSet>>,
/// Error message
pub(crate) error_message: String,
Expand All @@ -220,12 +224,20 @@ pub(crate) struct TaskInfo {
/// Task scheduled time
pub(super) scheduled_time: u128,
/// Task launch time
#[allow(dead_code)]
// we definitely need this one but we're not using it currently
pub(super) launch_time: u128,
/// Start execution time
#[allow(dead_code)]
// we definitely need this one but we're not using it currently
pub(super) start_exec_time: u128,
/// Finish execution time
#[allow(dead_code)]
// we definitely need this one but we're not using it currently
pub(super) end_exec_time: u128,
/// Task finish time
#[allow(dead_code)]
// we definitely need this one but we're not using it currently
pub(super) finish_time: u128,
/// Task Status
pub(super) task_status: task_status::Status,
Expand Down

0 comments on commit 96c6957

Please sign in to comment.