Skip to content

Commit

Permalink
fix issue with variable assignment
Browse files Browse the repository at this point in the history
  • Loading branch information
milenkovicm committed Feb 18, 2025
1 parent ca7d13b commit 09510df
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
10 changes: 3 additions & 7 deletions ballista/core/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,7 @@ const IO_RETRY_WAIT_TIME_MS: u64 = 3000;
impl BallistaClient {
/// Create a new BallistaClient to connect to the executor listening on the specified
/// host and port
pub async fn try_new(
host: &str,
port: u16,
grpc_client_max_message_size: usize,
) -> Result<Self> {
pub async fn try_new(host: &str, port: u16, max_message_size: usize) -> Result<Self> {
let addr = format!("http://{host}:{port}");
debug!("BallistaClient connecting to {}", addr);
let connection =
Expand All @@ -77,8 +73,8 @@ impl BallistaClient {
))
})?;
let flight_client = FlightServiceClient::new(connection)
.max_decoding_message_size(grpc_client_max_message_size)
.max_encoding_message_size(grpc_client_max_message_size);
.max_decoding_message_size(max_message_size)
.max_encoding_message_size(max_message_size);

debug!("BallistaClient connected OK: {:?}", flight_client);

Expand Down
5 changes: 2 additions & 3 deletions ballista/core/src/execution_plans/shuffle_reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,8 @@ impl ExecutionPlan for ShuffleReaderExec {

let config = context.session_config();

let max_request_num = config.ballista_grpc_client_max_message_size();
let max_message_size =
config.ballista_shuffle_reader_maximum_in_flight_requests();
let max_request_num = config.ballista_shuffle_reader_maximum_in_flight_requests();
let max_message_size = config.ballista_grpc_client_max_message_size();

log::debug!(
"ShuffleReaderExec::execute({}) max_request_num: {}, max_message_size: {}",
Expand Down

0 comments on commit 09510df

Please sign in to comment.