Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix order is not checked to be consistent #17

Open
bluss opened this issue Feb 8, 2016 · 2 comments
Open

Matrix order is not checked to be consistent #17

bluss opened this issue Feb 8, 2016 · 2 comments

Comments

@bluss
Copy link
Contributor

bluss commented Feb 8, 2016

In for example Gemm, the ordering of the input a is used, but this requires that a, b, c all have the same value for .order(). This is not checked.

@mikkyang
Copy link
Owner

Thanks for finding this! I'll check through the docs to see which functions I need to update.

@bluss
Copy link
Contributor Author

bluss commented Feb 21, 2016

Sure thing. I'm not sure what you want to do here, if you wanted to check or leave it to the user. I'm writing ndarray as you know, and ndarray is not 100% committed to rblas even if that is where we started. We may have to move to more direct blas bindings as we continue integration with blas/lapack. Thanks for working on rblas though, it has made it much easier for us to experiment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants