Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail for lack of internal registry if there are no internal images to copy #53

Open
sseago opened this issue Mar 18, 2020 · 0 comments

Comments

@sseago
Copy link
Collaborator

sseago commented Mar 18, 2020

Currently the plugin fails a backup or restore if it can't locate the internal registry. This is done in the common backup/restore plugin, which means it will fail a migration for missing the registry even if there are no internal images to copy.

Running without a registry is a valid cluster configuration. The common plugin (which sets annotations for src and dest registry location/hostname) should just not set the annotation if it's not found rather than failing. Any plugins that assume this annotation exists will need to be modified accordingly. Basically, if it's not set on src, assume there are no internal images. If it's not set on dest but it was set on src, then fail the restore if there are internal images to copy from the src/migration registry, but don't fail if there are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant