Investigate : Incomplete Path Parameters in TS

[rkodev]

Path generation in TS SDK seems to be missing some request builder properties

Example : https://docs.microsoft.com/en-us/graph/api/ediscovery-legalhold-delete?view=graph-rest-beta&tabs=go

ediscovery is missing in the RequestBuilder

const graphServiceClient = GraphServiceClient.init({authProvider});


const result = async () => {
	await graphServiceClient.compliance.ediscovery.casesById("case-id").legalHoldsById("legalHold-id").delete();
}

[rkodev]

cc @nikithauc @baywet

[baywet]

This API being under beta and this SDK being generated only for v1 I'd say this is expected? Unless the raptor process is generating a beta SDK on the fly?

[rkodev]

@baywet Had missed that, I'll investigate how the beta snippets were extracted when only v1 were specified in the E2E pipeline

[baywet]

no worries, besides that aspect, the path item is in the beta OpenAPI description at the moment '/compliance/ediscovery/cases/{case-id}/legalHolds/{legalHold-id}' and should get generated for.

[rkodev]

@baywet Another example generated from v1

Sample Link : https://docs.microsoft.com/en-us/graph/api/accessreviewinstance-batchrecorddecisions?view=graph-rest-beta&tabs=typescript

pendingAccessReviewInstancesById is missing from MeRequestBuilder

const authProvider = new AzureIdentityAuthenticationProvider(new ClientSecretCredential("tenantId", "clientId", "clientSecret")); 


//THIS SNIPPET IS A PREVIEW FOR THE KIOTA BASED SDK. NON-PRODUCTION USE ONLY
const graphServiceClient = GraphServiceClient.init({authProvider});

const requestBody : BatchRecordDecisionsPostRequestBody = {
	decision : "Approve",
	justification : "All principals with access need continued access to the resource (Marketing Group) as all the principals are on the marketing team",
	resourceId : "a5c51e59-3fcd-4a37-87a1-835c0c21488a",
};

async () => {
	await graphServiceClient.me.pendingAccessReviewInstancesById("accessReviewInstance-id").batchRecordDecisions.post(requestBody);
}

[baywet]

In this specific case "pendingAccessReviewInstances" is not present in the CSDL, all what's left are annotations trying to target it to say it's deprecated. I do think it's a separate issue from the one in the original post and should be looked into separately.

[rkodev]

@baywet Moved the second sample to a separate issue here microsoftgraph/msgraph-sdk-typescript#108

This current issue to be addressed in raptor

[baywet]

transferring to beta
this path is available here (on the SDK)
@rkodev is the issue for snippets generation?

msgraph-beta-sdk-typescript/packages/msgraph-beta-sdk-compliance/compliance/ediscovery/cases/item/legalHolds/item/index.ts

Line 36 in 247adb8

delete(requestConfiguration?: RequestConfiguration<object> | undefined) : Promise<void>;

[rkodev]

Closing this issue as its resolved in version v1.0.0-preview.33