feat: expose updated event on mgt components #3357
Conversation
makes updated event of MgtBaseTaskComponent accessible on Person control
|
@musale turns out there's already an updated event that's simply not exposed. Please check if that's a route that would be acceptable for you. |
|
@microsoft-github-policy-service agree |
| @@ -75,6 +75,7 @@ export const registerMgtPersonComponent = () => { | |||
| * @class MgtPerson | |||
| * @extends {MgtTemplatedComponent} | |||
| * | |||
| * @fires {CustomEvent<null>} updated - Fired when the component is updated | |||
There was a problem hiding this comment.
Add this to the https://github.com/microsoftgraph/microsoft-graph-toolkit/blob/main/packages/mgt-element/src/components/baseTaskComponent.ts file then re-run yarn build. This will generate the props for all components that fire the event. Then add this comment on the components whose generated files have been updated for consistent documentation.
| * @fires {CustomEvent<null>} updated - Fired when the component is updated | |
| * @fires {CustomEvent<undefined>} updated - Fired when the component is updated |
Thank you for surfacing this. I have left some comments. This is a really good catch. |
|
I updated the components as suggested. Do you want me to add the update events to all components in Storybook as well? |
Yes, that would be very helpful. |
musale
changed the title
|
updated all the stories |
makes existing
updatedevent ofMgtBaseTaskComponentaccessible on MgtPerson controlCloses #3352
PR Type
Feature
Description of the changes
updatedwill fire whenever the control is re-rendered, e.g. when switching from loading to displaying the downloaded data.PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information