Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Constant design-token.js errors #3340

Closed
dougroutledge opened this issue Nov 1, 2024 · 9 comments · Fixed by #3354
Closed

[BUG] Constant design-token.js errors #3340

dougroutledge opened this issue Nov 1, 2024 · 9 comments · Fixed by #3354
Labels
bug Something isn't working Needs: Attention 👋 Issue needs attention from mantainers State: In Review

Comments

@dougroutledge
Copy link

Since version 4.3 the browser console is polluted with thousands of of the same error.

image

It seems to be related to the underlying fluent UI being used by MGT.

@dougroutledge dougroutledge added bug Something isn't working Needs: Triage 🔍 labels Nov 1, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Graph Toolkit Nov 1, 2024
@musale
Copy link
Contributor

musale commented Nov 4, 2024

@dougroutledge is this happening on a specific component and framework?

@musale musale added the Needs: Author Feedback Issue needs response from issue author label Nov 4, 2024
@dougroutledge
Copy link
Author

It doesn't seem to be any specific components, it errors constantly whether they are in use or not.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Issue needs attention from mantainers and removed Needs: Author Feedback Issue needs response from issue author no-recent-activity labels Nov 8, 2024
@musale
Copy link
Contributor

musale commented Nov 21, 2024

What about the framework you're using? React, plain js etc? Please fill out the environment details to enable reproduction
Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. edge, chrome, safari]
  • Framework [e.g. react, vue, none]
  • Context [e.g. Microsoft Teams, SharePoint, Office Add-ins, Web]
  • Version [e.g. 0.1]
  • Provider [e.g. Msal2Provider] (bonus if you share the provider config)

@musale musale added Needs: Author Feedback Issue needs response from issue author and removed Needs: Attention 👋 Issue needs attention from mantainers labels Nov 21, 2024
@dougroutledge
Copy link
Author

OS: Any
Browser Any
Framework JS no framework
Context Web
Version 4.4.0
Provider Msal2Provider

const msalConfig = {
auth: {
clientId: "!removed!",
scopes: [ "profile", "email", "Calendars.Read", "Calendars.Read.Shared", "Chat.Read", "Chat.ReadWrite", "Contacts.Read", "Contacts.Read.Shared", "email", "Mail.Read", "Mail.Read.Shared", "Notifications.ReadWrite.CreatedByApp", "People.Read", "profile", "User.Read", "User.ReadBasic.All", "UserNotification.ReadWrite.CreatedByApp", "User.Read.All"],
loginType: "Popup",
forceRefresh: true
},
cache: {
cacheLocation: "sessionStorage", // This configures where your cache will be stored
storeAuthStateInCookie: false, // Set this to "true" if you are having issues on IE11 or Edge
}
};

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Issue needs attention from mantainers and removed Needs: Author Feedback Issue needs response from issue author labels Nov 21, 2024
@ThomasPe
Copy link

Same for me specifically on the PeoplePicker in React

  • Windows
  • Edge
  • Microsoft Teams
  • Version: ^4.2.1
  • TeamsFxProvider

@dougroutledge
Copy link
Author

This is becoming a major issue, it is rendering complex pages unresponsive when no mgt controls on the page are even visible. The underlying MS fast elements library seems unable to deal with circular references or anything more complicated than a very basic static page. Browser reporting hung status as it spews thousands of lines of this.
image When did this project switch to being dependent on fluent / fast elements? Can I have the date and version?

@Mnickii
Copy link
Collaborator

Mnickii commented Dec 20, 2024

Hi @dougroutledge, the team is currently looking into this.

The project was built using Fluent Web components and in June last year we migrated to Fluent Web components v2 on our v3.0.0 release. These components are dependent on Fast elements.

@ThomasPe
Copy link

ThomasPe commented Dec 29, 2024

issue was introduced with @microsoft/fast-foundation version 2.50.0
I was able to mitigate the issue by pinning the version to:
"@microsoft/fast-foundation": "2.49.6",
in the package.json

Edit: Repro https://stackblitz.com/edit/d5ahzhyb?file=src%2FApp.tsx

@musale
Copy link
Contributor

musale commented Jan 2, 2025

issue was introduced with @microsoft/fast-foundation version 2.50.0 I was able to mitigate the issue by pinning the version to: "@microsoft/fast-foundation": "2.49.6", in the package.json

Edit: Repro stackblitz.com/edit/d5ahzhyb?file=src%2FApp.tsx

Thank you @ThomasPe for this, I am able to reproduce this locally. What I see is that using the theme toggle with any component throws the range errors. On further scrutiny of the errors, the issue lies with fast-foundation updates in 2.50.0. This work around should work for now. I am also going to pin the version of fast-foundation to 2.49.6 in our latest release until a fix is made by the fast team. We shall monitor microsoft/fast#7057 for this. Cc @dougroutledge please let us know if this workaround works for you for now.

package.json

"resolutions": {
  "@microsoft/fast-foundation": "2.49.6"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs: Attention 👋 Issue needs attention from mantainers State: In Review
Projects
Status: Done ✔️
4 participants