Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Request]: Move Google Chrome MSI to https://github.com/microsoft/winget-pkgs/tree/master/manifests/g/Google/Chrome/MSI #205770

Open
rovabunw opened this issue Jan 3, 2025 · 2 comments
Labels
Help-Wanted This is a good candidate work item from the community. Package-Metadata

Comments

@rovabunw
Copy link
Contributor

rovabunw commented Jan 3, 2025

What type of update are you requesting?

A change to the package metadata

Current Package Identifier

Google.Chrome

Package Version

131.0.6778.205

Please describe the changes you would like to see

  1. Move version

This one https://github.com/microsoft/winget-pkgs/tree/master/manifests/g/Google/Chrome/131.0.6778.205
should moved to a separate directory similar to:
https://github.com/microsoft/winget-pkgs/tree/master/manifests/g/Google/Chrome/EXE

  1. Create Directory MSI

suggestion: https://github.com/microsoft/winget-pkgs/tree/master/manifests/g/Google/Chrome/**MSI**

  1. change PackageIdentifier

And the PackageIdentifier should be changed from Google.Chrome to Google.Chrome**.MSI**

@rovabunw rovabunw added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Jan 3, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage This work item needs to be triaged by a member of the core team. Package-Metadata and removed Package-Update This package needs to be updated labels Jan 3, 2025
@rovabunw rovabunw changed the title [Update Request]: Moved Google Chrome MSI to https://github.com/microsoft/winget-pkgs/tree/master/manifests/g/Google/Chrome/MSI [Update Request]: Move Google Chrome MSI to https://github.com/microsoft/winget-pkgs/tree/master/manifests/g/Google/Chrome/MSI Jan 3, 2025
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 3, 2025
@Dragon1573
Copy link
Contributor

I think it would be better NOT moving them.

Except identifier Google.Chrome.Canary (which using exe by default), other identifier including Google.Chrome, Google.Chrome.Beta, Google.Chrome.Dev, Google.Chrome all using wix by default. Each of them provides .EXE identifier suffix version.

They've already been distinguished.

@Trenly
Copy link
Contributor

Trenly commented Jan 3, 2025

I agree that it should not be moved, as it would be a breaking change for any automations or workflows that are expecting to be able to use winget install Google.Chrome . Were it a package that is less popular, I'd be more inclined to move it, but Google Chrome is one of the more popular packages which increases the likelihood that automations have been built around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community. Package-Metadata
Projects
None yet
Development

No branches or pull requests

4 participants