Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Changelog #3334

Closed
konstin opened this issue Oct 30, 2024 · 4 comments
Closed

Provide a Changelog #3334

konstin opened this issue Oct 30, 2024 · 4 comments
Labels
question Further information is requested

Comments

@konstin
Copy link

konstin commented Oct 30, 2024

Suggestion

The update of windows-registry to 0.3.0 had multiple breaking changes (https://github.com/astral-sh/uv/actions/runs/11590087174/job/32266949119?pr=7796), but I can't find any overview over the breaking changed and how to migrate apart from the all-crate commit list. Could each crate provide a changelog, specifically with the breaking changes highlighted?

@konstin konstin added the enhancement New feature or request label Oct 30, 2024
@kennykerr
Copy link
Collaborator

Thanks for the feedback. We have release notes here:

https://github.com/microsoft/windows-rs/releases

There you can see, for example, a few changes related to registry support.

@kennykerr kennykerr added question Further information is requested and removed enhancement New feature or request labels Oct 30, 2024
@konstin
Copy link
Author

konstin commented Oct 30, 2024

I have read that changelog, there seemed to be a lot of internal changes listed, but i e.g. didn't see the Value enum being converted to a struct with private fields being mentioned, which was the one breaking change we observed.

@kennykerr
Copy link
Collaborator

That would be #3184.

@kennykerr
Copy link
Collaborator

I'm just not in a position to commit to providing dedicated change logs for all crates at this time, but I will certainly endeavor to more clearly call out specific breaking changes. This particular change was a bit of a collaboration with the rustup team who needed a lot more control over data representation and ended up being more substantial than I anticipated. I'm sorry for any difficulty this caused, but I'm glad to see you figured out the migration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants