Build failure with 0.52.1 release

[ctz]

Summary

Over in https://github.com/rustls/rustls, if we do cargo update we get these changes to Cargo.lock:

diff --git a/Cargo.lock b/Cargo.lock
index 82b689c0..211487ad 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2911,13 +2911,13 @@ version = "0.52.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "8a18201040b24831fbb9e4eb208f8892e1f50a37feb53cc7ff887feb8f50e7cd"
 dependencies = [
- "windows_aarch64_gnullvm 0.52.0",
- "windows_aarch64_msvc 0.52.0",
- "windows_i686_gnu 0.52.0",
- "windows_i686_msvc 0.52.0",
- "windows_x86_64_gnu 0.52.0",
- "windows_x86_64_gnullvm 0.52.0",
- "windows_x86_64_msvc 0.52.0",
+ "windows_aarch64_gnullvm 0.52.1",
+ "windows_aarch64_msvc 0.52.1",
+ "windows_i686_gnu 0.52.1",
+ "windows_i686_msvc 0.52.1",
+ "windows_x86_64_gnu 0.52.1",
+ "windows_x86_64_gnullvm 0.52.1",
+ "windows_x86_64_msvc 0.52.1",
 ]
 
 [[package]]
@@ -2928,9 +2928,9 @@ checksum = "2b38e32f0abccf9987a4e3079dfb67dcd799fb61361e53e2882c3cbaf0d905d8"
 
 [[package]]
 name = "windows_aarch64_gnullvm"
-version = "0.52.0"
+version = "0.52.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "cb7764e35d4db8a7921e09562a0304bf2f93e0a51bfccee0bd0bb0b666b015ea"
+checksum = "e7269c1442e75af9fa59290383f7665b828efc76c429cc0b7f2ecb33cf51ebae"
 
 [[package]]
 name = "windows_aarch64_msvc"
@@ -2940,9 +2940,9 @@ checksum = "dc35310971f3b2dbbf3f0690a219f40e2d9afcf64f9ab7cc1be722937c26b4bc"
 
 [[package]]
 name = "windows_aarch64_msvc"
-version = "0.52.0"
+version = "0.52.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "bbaa0368d4f1d2aaefc55b6fcfee13f41544ddf36801e793edbbfd7d7df075ef"
+checksum = "f70ab2cebf332b7ecbdd98900c2da5298a8c862472fb35c75fc297eabb9d89b8"
 
 [[package]]
 name = "windows_i686_gnu"
@@ -2952,9 +2952,9 @@ checksum = "a75915e7def60c94dcef72200b9a8e58e5091744960da64ec734a6c6e9b3743e"
 
 [[package]]
 name = "windows_i686_gnu"
-version = "0.52.0"
+version = "0.52.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a28637cb1fa3560a16915793afb20081aba2c92ee8af57b4d5f28e4b3e7df313"
+checksum = "679f235acf6b1639408c0f6db295697a19d103b0cdc88146aa1b992c580c647d"
 
 [[package]]
 name = "windows_i686_msvc"
@@ -2964,9 +2964,9 @@ checksum = "8f55c233f70c4b27f66c523580f78f1004e8b5a8b659e05a4eb49d4166cca406"
 
 [[package]]
 name = "windows_i686_msvc"
-version = "0.52.0"
+version = "0.52.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ffe5e8e31046ce6230cc7215707b816e339ff4d4d67c65dffa206fd0f7aa7b9a"
+checksum = "3480ac194b55ae274a7e135c21645656825da4a7f5b6e9286291b2113c94a78b"
 
 [[package]]
 name = "windows_x86_64_gnu"
@@ -2976,9 +2976,9 @@ checksum = "53d40abd2583d23e4718fddf1ebec84dbff8381c07cae67ff7768bbf19c6718e"
 
 [[package]]
 name = "windows_x86_64_gnu"
-version = "0.52.0"
+version = "0.52.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3d6fa32db2bc4a2f5abeacf2b69f7992cd09dca97498da74a151a3132c26befd"
+checksum = "42c46bab241c121402d1cb47d028ea3680ee2f359dcc287482dcf7fdddc73363"
 
 [[package]]
 name = "windows_x86_64_gnullvm"
@@ -2988,9 +2988,9 @@ checksum = "0b7b52767868a23d5bab768e390dc5f5c55825b6d30b86c844ff2dc7414044cc"
 
 [[package]]
 name = "windows_x86_64_gnullvm"
-version = "0.52.0"
+version = "0.52.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1a657e1e9d3f514745a572a6846d3c7aa7dbe1658c056ed9c3344c4109a6949e"
+checksum = "dc885a4332ee1afb9a1bacf11514801011725570d35675abc229ce7e3afe4d20"
 
 [[package]]
 name = "windows_x86_64_msvc"
@@ -3000,9 +3000,9 @@ checksum = "ed94fce61571a4006852b7389a063ab983c02eb1bb37b47f8272ce92d06d9538"
 
 [[package]]
 name = "windows_x86_64_msvc"
-version = "0.52.0"
+version = "0.52.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "dff9641d1cd4be8d1a070daf9e3773c5f67e78b4d9d42263020c057706765c04"
+checksum = "9e440c60457f84b0bee09208e62acc7ade264b38c4453f6312b8c9ab1613e73c"
 
 [[package]]
 name = "winreg"

These no longer build for us:

Passing build: https://github.com/rustls/rustls/actions/runs/8007100707/job/21870380913
Failing build: https://github.com/rustls/rustls/actions/runs/8006652051/job/21868892390
Diff between those builds: https://github.com/rustls/rustls/compare/e94f3f267081443f3742dfaab815bb9483fafa52..dd3377bb5a45e33dcf1256e560a806d0e3467f40

error: linking with `link.exe` failed: exit code: 1181
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.39.33519\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustc1XsHdT\\symbols.o" "D:\\a\\rustls\\rustls\\target\\debug\\build\\aws-lc-sys-c3bb0580efd37689\\build_script_main-c3bb0580efd37689.build_script_main.6f8c0b1f309f1198-cgu.0.rcgu.o" "D:\\a\\rustls\\rustls\\target\\debug\\build\\aws-lc-sys-c3bb0580efd37689\\build_script_main-c3bb0580efd37689.build_script_main.6f8c0b1f309f1198-cgu.1.rcgu.o" "D:\\a\\rustls\\rustls\\target\\debug\\build\\aws-lc-sys-c3bb0580efd37689\\build_script_main-c3bb0580efd37689.4s4pfeiojz19pe03.rcgu.o" "/LIBPATH:D:\\a\\rustls\\rustls\\target\\debug\\deps" "/LIBPATH:C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\windows_x86_64_msvc-0.48.5\\lib" "/LIBPATH:C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\windows_x86_64_msvc-0.52.1\\lib" "/LIBPATH:C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libfs_extra-e4d4f52519c19377.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libdunce-a2d9e0fecfa6232c.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libcmake-585777b22a1e449e.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libcc-655291662ad67663.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libbindgen-1d6b085e5fd18854.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libprettyplease-99e764de7d7f42e9.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libwhich-be582a767fd80146.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libonce_cell-2ef8eb3cc292aaa0.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libhome-2e9e22ebcb1e85c7.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libwindows_sys-a8f392d412c20c43.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libwindows_targets-b6da7fa65a26b732.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libshlex-adb99b961f5a23a7.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\librustc_hash-f14c14f8e118bef3.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libregex-0cb490f19ff537a7.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libregex_automata-86c2a1dab654e0c6.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libregex_syntax-11d6dea04bacf1e4.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\liblazycell-93e170697991324f.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libitertools-614e590a353f43cf.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libeither-e287869222db1dba.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libcexpr-41b8bca6ece2acbd.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libnom-ef3337294132570f.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libmemchr-270a18fa33a31d5a.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libclang_sys-d2bd447d8ac29e96.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\liblibloading-a9424b7cdb25198d.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libwindows_sys-6cf236b4fb963f79.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libwindows_targets-5ed392ba99a296da.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\liblibc-bbb9ed7415fcb865.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libglob-cfc142b71c389494.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libsyn-7216a0027798718d.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\liblog-4e7c53dc3a67e1da.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libquote-448d405c25da8546.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libproc_macro2-7610ce373cca0023.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libunicode_ident-5ea8f212918f5c2b.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libproc_macro-8e26389e45c3b56c.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\liblazy_static-a74cec1b63bee500.rlib" "D:\\a\\rustls\\rustls\\target\\debug\\deps\\libbitflags-0ebca13403b84e21.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-e493bcbfdc66a475.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-467acea86c440d1f.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-8bcec20f8d868561.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_detect-e75d865d889e433e.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-cd24a5810f58b720.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-44b4ecbbc95939b2.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-ff93d2b34eb6aecc.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-17346c417f0e9166.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liblibc-ff5a06ebf4571d10.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-cb2478631e21007b.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-58d59322b34f2b51.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-c192803e6895f627.rlib" "C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-20106e86b5dab94f.rlib" "advapi32.lib" "kernel32.lib" "ole32.lib" "oleaut32.lib" "windows.0.52.0.lib" "windows.0.48.5.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "advapi32.lib" "bcrypt.lib" "kernel32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "kernel32.lib" "ws2_32.lib" "kernel32.lib" "ntdll.lib" "kernel32.lib" "msvcrt.lib" "/NXCOMPAT" "/LIBPATH:C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "/OUT:D:\\a\\rustls\\rustls\\target\\debug\\build\\aws-lc-sys-c3bb0580efd37689\\build_script_main-c3bb0580efd37689.exe" "/OPT:REF,NOICF" "/DEBUG" "/NATVIS:C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:C:\\Users\\runneradmin\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libstd.natvis"
  = note: LINK : fatal error LNK1181: cannot open input file 'windows.0.52.0.lib'

Crate manifest

https://github.com/rustls/rustls/

Crate code

No code changes.

[kennykerr]

I think I know what the problem is - stand by.

[kennykerr]

This should do it: #2870

[kennykerr]

The windows-targets crate has now been updated.

[bonigarcia]

Hello. I'm experiencing this same problem a GH Actions workflow in a Windows worker:

https://github.com/SeleniumHQ/selenium/actions/runs/9159984598/job/25182073761

Do you know how to avoid this problem? Thanks in advance.