Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe breaks syntax highlighting for Ini files #21804

Closed
thijsvandien opened this issue Mar 2, 2017 · 1 comment
Closed

Apostrophe breaks syntax highlighting for Ini files #21804

thijsvandien opened this issue Mar 2, 2017 · 1 comment
Assignees

Comments

@thijsvandien
Copy link

thijsvandien commented Mar 2, 2017

  • VSCode Version: Code 1.10.1 (653f873, 2017-03-02T00:27:09.350Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions:
Extension Author Version
python donjayamanne 0.5.9
vim vscodevim 0.5.3

Steps to Reproduce:

  1. Create an ini file where a text value contains an apostrophe in the middle, e.g.:
[Sample]
SomeKey=Someone's Value
SomeOtherKey=42
  1. Note that from the apostrophe onward, the rest of the file is considered a string.

Different ini implementations have their own interpretations of values. E.g., Windows does not consider the apostrophes of a quoted value part of that value. I'm not aware of the exact rules, but at least the current highlighting behavior is wrong. I think it would be better to stick to the universally valid rules – sections, keys and values – and not to consider apostrophes special at all.

@aeschli
Copy link
Contributor

aeschli commented Mar 31, 2017

This issue was moved to textmate/ini.tmbundle#3

@aeschli aeschli closed this as completed Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants