Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users when installing an extension from a publisher for the first time #215527

Closed
1 task
isidorn opened this issue Jun 14, 2024 · 2 comments · Fixed by #238540
Closed
1 task

Notify users when installing an extension from a publisher for the first time #215527

isidorn opened this issue Jun 14, 2024 · 2 comments · Fixed by #238540
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 14, 2024

To start I propose we do a similar solution like Intelli-J. On extension install we show a dialog with the following text

"EXTENSION NAME is coming from EXTENSION_AUTHOR. Installing extensions is similar to installing and running applications. Extensions get the same permissions as PRODUCT_NAME itself. Only proceed if you trust EXTENSION_AUTHOR."

  • Always trust extensions from EXTENSION_AUTHOR

"Cancel" "Learn More" "Install"

Always trust extensions from EXTENSION_AUTHOR would go to machine storage. By default Microsoft and GitHub would be trusted - since the user already placed their trust in VS Code.

Learn More would take users to doc (@isidorn to author - tracked microsoft/vscode-docs#7874)

We also need command to manage the preserved state.

I think this will be a better fit than workspace trust, since we actually show the dialog at the right moment (when user is installing an extension). Unlike on startup with workspace trust.

Step 2 (out of scope of this issue) is to show additional information in this dialog. For example:

  • Name / publisher name (verified)
  • Ratings
  • Repository (with some metadata if it actually belongs to publisher)
  • Install Count
  • Last published
@isidorn isidorn added extensions Issues concerning extensions feature-request Request for new features or functionality labels Jun 14, 2024
@isidorn isidorn added this to the Backlog milestone Jun 14, 2024
@isidorn isidorn modified the milestones: Backlog, July 2024 Jun 18, 2024
@isidorn
Copy link
Contributor Author

isidorn commented Jun 18, 2024

Putting to July, just because I do not want already to create the August milestone. As soon as it gets created will move this issue to that milestone.

@isidorn isidorn modified the milestones: July 2024, August 2024 Jul 19, 2024
@isidorn
Copy link
Contributor Author

isidorn commented Jul 19, 2024

@ulugbekna made a good point that intelli-j shows a dialog on install for 3rd parties "proceed with caution". Here's how it looks

Image

Full text used

"The following plugins aren't coming from JetBrains:   

AWS Toolkit (Amazon Web Services)

Installing plugins is similar to installing and running applications. Plugins get the same permissions as the IDE process itself. Only proceed if you trust the plugins.

You are also advised to check the plugin vendor’s documentation for details on how the vendor can process your personal data. JetBrains is not responsible for any behavior of any third-party plugins and their vendors, including processing of your personal data."

fyi @sandy081 @alexdima @joaomoreno

@isidorn isidorn modified the milestones: August 2024, September 2024 Aug 29, 2024
@isidorn isidorn modified the milestones: September 2024, Backlog Sep 23, 2024
@isidorn isidorn assigned sandy081 and unassigned daviddossett Nov 22, 2024
@isidorn isidorn changed the title Transparently show extension metadata on install Notify users of extension runtime model on extension install Dec 17, 2024
@sandy081 sandy081 modified the milestones: Backlog, January 2025 Jan 16, 2025
@sandy081 sandy081 changed the title Notify users of extension runtime model on extension install Notify users when installing an extension from a publisher for the first time Jan 21, 2025
sandy081 added a commit that referenced this issue Jan 21, 2025
sandy081 added a commit that referenced this issue Jan 23, 2025
…st time (#238540)

* #215527 Notify users when installing an extension from a publisher for the first time

* feedback

* polish

* trust publishers post installing

* add verify publisher link

* tweak wording

* tweak wording

* add quotes

* add telelemtry
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 23, 2025
@sandy081 sandy081 added on-testplan and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 23, 2025
HD787 pushed a commit to HD787/vscode that referenced this issue Jan 24, 2025
…st time (microsoft#238540)

* microsoft#215527 Notify users when installing an extension from a publisher for the first time

* feedback

* polish

* trust publishers post installing

* add verify publisher link

* tweak wording

* tweak wording

* add quotes

* add telelemtry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants