Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] exclude single quote from autoClosingPairs for element content #18541

Closed
ghost opened this issue Jan 14, 2017 · 2 comments
Closed

[html] exclude single quote from autoClosingPairs for element content #18541

ghost opened this issue Jan 14, 2017 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality html HTML support issues
Milestone

Comments

@ghost
Copy link

ghost commented Jan 14, 2017

  • VSCode Version: Code 1.8.1 (ee428b0, 2016-12-19T14:49:23.350Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version

Steps to Reproduce:

  1. Create an html file
  2. Create a paragraph tag and use single quotes for typing a sentence such as we're.

The output displays the following

We're'

Also when tabbing out of quotes such as
The output displays the following

</style>"

Steps to Reproduce:

  1. Type <link rel="
  2. The program will auto insert another set of quotes
  3. It will change to this <link rel=""
  4. Type <link rel="stylesheet"
  5. The cursor is between t and "
  6. Press tab
  7. The output inserts open and close tags for
@dbaeumer dbaeumer added the html HTML support issues label Jan 16, 2017
@aeschli aeschli changed the title HTML buggy in VS Code [html] exclude single quote from autoClosingPairs for element content Jan 19, 2017
@aeschli aeschli added this to the Backlog milestone Jan 19, 2017
@aeschli
Copy link
Contributor

aeschli commented Jan 30, 2017

I agree we should refine this. #19515 has a good idea.

@aeschli aeschli added the feature-request Request for new features or functionality label Jan 30, 2017
@alexdima alexdima removed their assignment Jun 1, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2017

Since a while, single and double quotes are not autoclosed if typed directly after a letter. That fixes the we're case.
Also, the <link rel="stylesheet" is no longer reproducible, there must have been some changes.
Closing

@aeschli aeschli closed this as completed Nov 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality html HTML support issues
Projects
None yet
Development

No branches or pull requests

3 participants